Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[google-cloud-cpp] add missing subpackage #24626

Merged
merged 1 commit into from
May 10, 2022
Merged

[google-cloud-cpp] add missing subpackage #24626

merged 1 commit into from
May 10, 2022

Conversation

coryan
Copy link
Contributor

@coryan coryan commented May 9, 2022

Add a missing vcpkg_cmake_config_fixup() for a

  • What does your PR fix?

Fixes googleapis/google-cloud-cpp#8919

  • Which triplets are supported/not supported? Have you updated the CI baseline?

N/A

Yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

Yes.

Tested locally with vcpkg install google-cloud-cpp[core,storage]. Also tested with this Docker script:

FROM ubuntu:22.04

RUN apt-get update && \
    apt-get --no-install-recommends install -y apt-transport-https apt-utils \
        automake build-essential ca-certificates ccache cmake curl git \
        gcc g++ libc-ares-dev libc-ares2 libcurl4-openssl-dev libre2-dev \
        libssl-dev m4 make ninja-build pkg-config tar wget zlib1g-dev

RUN apt-get update && apt-get --no-install-recommends install -y zip unzip tar cmake ninja-build

WORKDIR /var/tmp/build/vcpkg
RUN curl -sSL https://github.com/coryan/vcpkg/archive/d6f0a18c632b73cb5ee2e44e5ee1079a4f5832b4.tar.gz | \
     tar -xzf - --strip-components=1

RUN ./bootstrap-vcpkg.sh
RUN ./vcpkg install google-cloud-cpp[core,storage]

WORKDIR /var/tmp/build/google-cloud-cpp
RUN curl -sSL https://github.com/googleapis/google-cloud-cpp/archive/refs/tags/v1.40.1.tar.gz | \
     tar -xzf - --strip-components=1

WORKDIR /var/tmp/build/google-cloud-cpp/google/cloud/storage/quickstart
RUN cmake -H. -B.build -DCMAKE_TOOLCHAIN_FILE=/var/tmp/build/vcpkg/scripts/buildsystems/vcpkg.cmake
RUN cmake --build .build

@LilyWangLL LilyWangLL added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label May 10, 2022
@LilyWangLL LilyWangLL added the info:reviewed Pull Request changes follow basic guidelines label May 10, 2022
@BillyONeal BillyONeal merged commit a6a97cd into microsoft:master May 10, 2022
@BillyONeal
Copy link
Member

Thanks for the patch!

@coryan coryan deleted the google-cloud-cpp-add-missing-subpackage branch June 6, 2023 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LilyWangLL LilyWangLL LilyWangLL approved these changes

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees

@LilyWangLL LilyWangLL

Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Could not find a package configuration file provided by "google_cloud_cpp_rest_internal"
3 participants
@coryan @BillyONeal @LilyWangLL